Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skaffold: 0.35.0 -> 0.36.0 #67512

Merged
merged 1 commit into from Aug 27, 2019
Merged

skaffold: 0.35.0 -> 0.36.0 #67512

merged 1 commit into from Aug 27, 2019

Conversation

jlesquembre
Copy link
Member

Motivation for this change

skaffold: 0.35.0 -> 0.36.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vdemeester

@vdemeester
Copy link
Member

@GrahamcOfBorg build skaffold

vdemeester
vdemeester approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@mmahut
Copy link
Member

mmahut commented Aug 27, 2019

@GrahamcOfBorg build skaffold

@mmahut mmahut merged commit c0e2e09 into NixOS:master Aug 27, 2019
@jlesquembre jlesquembre deleted the skaffold branch August 27, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlesquembre @vdemeester @mmahut