Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-desktop: use yarn2nix-moretea #67514

Closed
wants to merge 1 commit into from
Closed

riot-desktop: use yarn2nix-moretea #67514

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2019 •
edited by ghost

Motivation for this change

Now that we have yarn2nix-moretea in the tree, we can use that instead of the vendored version that was introduced when yarn2nix was removed previously.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

riot-desktop: use yarn2nix-moretea
b840c96 
Now that we have yarn2nix-moretea in the tree, we can use that instead of the vendored version that was introduced when yarn2nix was removed previously.
@ghost
Copy link
Author

ghost commented Aug 26, 2019

cc @pacien @worldofpeace

@ofborg ofborg bot requested a review from worldofpeace August 26, 2019 17:23
worldofpeace
worldofpeace reviewed Aug 26, 2019
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -1922,7 +1922,9 @@ in

ring-daemon = callPackage ../applications/networking/instant-messengers/ring-daemon { };

riot-desktop = callPackage ../applications/networking/instant-messengers/riot/riot-desktop.nix { };
riot-desktop = callPackage ../applications/networking/instant-messengers/riot/riot-desktop.nix {
yarn2nix = yarn2nix-moretea;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use yarn2nix-moretea directly.

@pacien
Copy link
Contributor

pacien commented Aug 26, 2019

Would using yarn.lock directly and letting yarn2nix generate yarn.nix automatically be allowed in nixpkgs? I'm not sure whether it would have an impact on the evaluation time, but it would simplify the maintenance of this package.

@ghost
Copy link
Author

ghost commented Aug 26, 2019

Would using yarn.lock directly and letting yarn2nix generate yarn.nix automatically be allowed in nixpkgs? I'm not sure whether it would have an impact on the evaluation time, but it would simplify the maintenance of this package.

It's not possible with Hydra (yet).

@pacien pacien mentioned this pull request Aug 26, 2019
Closed
10 tasks
@pacien
Copy link
Contributor

pacien commented Aug 26, 2019

Ok, I added an update script as well in #67528.

@ghost
Copy link
Author

ghost commented Aug 26, 2019

closing in favor of #67528

@ghost ghost closed this Aug 26, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pacien @worldofpeace