Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sharing in gnome-control-center #67549

Merged
merged 2 commits into from Aug 27, 2019
Merged

Fix sharing in gnome-control-center #67549

merged 2 commits into from Aug 27, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

It appears that if gnome-control-center isn't wrapped with the schemas for gnome-user-share or gnome-remote-desktop they aren't added to the sharing pane. These are optional features so I'm curious what will happen if someone disables the os services.

8a24bc2 fixes what was essentially sessionPath in the gnome-user-share module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
gnome3.gnome-control-center: add optional sharing deps
f1ce41d 
It appears that if gnome-control-center isn't wrapped with their
schemas they won't be added to the panel.
@worldofpeace
nixos/gnome-user-share: cleanup
8a24bc2 
* No sessionPath!

* add to systemd.packages
  This is for the gnome-user-share-webdav.service.

* Update option description
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 8.has: module (update) labels Aug 27, 2019
@ofborg ofborg bot requested review from hedning and jtojnar August 27, 2019 07:31
@jtojnar
Copy link
Contributor

jtojnar commented Aug 27, 2019

Hmm, I wonder why did Luca make it that way. Perhaps wanted to avoid lighttpd as a dependency of g-c-c.

Looks good though.

@worldofpeace
Copy link
Contributor Author

Checked that gnome-control-center shows File Sharing and Screen Sharing dialogs.

@jtojnar
Copy link
Contributor

jtojnar commented Aug 27, 2019

Looks good: https://gitlab.gnome.org/GNOME/gnome-control-center/blob/3.32.2/panels/sharing/cc-sharing-panel.c#L1185-1191

@worldofpeace worldofpeace merged commit 156f335 into NixOS:master Aug 27, 2019
@worldofpeace worldofpeace deleted the gnome-control-center/fix-sharing branch August 27, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar