Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

valgrind: fix shebang in outputs #67548

Closed
wants to merge 3 commits into from
Closed

valgrind: fix shebang in outputs #67548

wants to merge 3 commits into from

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Aug 27, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from edolstra August 27, 2019 07:14
@mmahut
Copy link
Member

mmahut commented Aug 27, 2019

Please point his mass rebuild to staging.

@worldofpeace
remove patchShebangs in script
07aee2a 
Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
@oxalica
Copy link
Contributor Author

oxalica commented Aug 29, 2019

Should I change the target branch to merge? @mmahut

@FRidh
Copy link
Member

FRidh commented Aug 31, 2019

Perl is also in nativeBuildInputs. Is it needed during build-time, run-time, or both, which this PR would imply.

@oxalica
Copy link
Contributor Author

oxalica commented Aug 31, 2019

Seems Perl is only required during run-time, and is now removed from nativeBuildInputs.

BTW: I found some absolute paths like /usr/*lib*, /*lib*/ and /*libc-2.27*.so in result/lib/valgrind/default.supp not getting substituted in postInstall. I'm not quite sure whether it is expected. Help? @eelco

@worldofpeace
Copy link
Contributor

merged in d22b485

@oxalica oxalica deleted the fix-valgrind-shebang branch September 25, 2019 04:14
samueldr added a commit to samueldr/nixpkgs that referenced this pull request Nov 18, 2019
@samueldr
valgrind: Add perl as a native build input
0213228 
The changes in NixOS#67548 broke cross-compilation not for valgrind, but for
software relying on valgrind at build-time.
@samueldr samueldr mentioned this pull request Nov 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@ck3d ck3d ck3d approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oxalica @mmahut @FRidh @worldofpeace @ck3d