Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update some coreboot-related packages #67547

Closed
wants to merge 6 commits into from
Closed

update some coreboot-related packages #67547

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 27, 2019 •
edited by ghost

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ghost
Copy link
Author

ghost commented Aug 27, 2019

Some Xen stuff fails to build, I will have a look if this is caused by the seabios update or if it was failing before.

@ghost
Copy link
Author

ghost commented Aug 27, 2019

cc @tstrobel @gnidorah @cryptix

@ghost
Copy link
Author

ghost commented Aug 27, 2019 •
edited by ghost

Actually the xen 4.10 packages failed to build even before the seabios update, so we should be ok

FYI nix-review said this:

4 package failed to build:
qemu_xen_4_10 qemu_xen_4_10-light xenPackages.xen_4_10-light xenPackages.xen_4_10-slim

11 package were build:
OVMF-CSM cbfstool cbmem ifdtool intelmetool nvramtool qemu_xen qemu_xen-light seabios xen-light xen-slim

ghost
ghost approved these changes Aug 27, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated intelmetool works for me

@ghost
Copy link
Author

ghost commented Aug 31, 2019

I will replace this with a PR merging all coreboot util packages into one for easier maintenance in the future.

@ghost ghost closed this Aug 31, 2019
@ghost
Copy link
Author

ghost commented Aug 31, 2019

superseeded by #67836

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
0 participants