xxdiff: drop the old qt4 version in favour of qt5 #67498
Conversation
|
@GrahamcOfBorg build xxdiff xxdiff-tip |
|
@GrahamcOfBorg build xxdiff |
|
@GrahamcOfBorg build xxdiff |
|
What's going on with the source? |
Do you mind trying to do nix-prefetch-url on your side? When I do it here, I get the same sum as as in the PR. |
|
Wait, Local build produces the same hash mismatch error as ofBorg. |
That's so strange - it works perfectly fine here. |
|
And if you GC the output of |
You're a star! That did it. |
|
Why build-time |
Because if we set |
|
Because if we set ```sourceRoot```, only the ```src``` directory gets copied over to the build directory so we no longer have access to the README that needs copying in at install time.
This is not what is defined in `setup.sh`, and not what happens in practice if I set `sourceRoot` to be `source/src`
Additionally, we would have to patch the make files to not place the output in ```../bin```.
Ah right, writing outside `sourceRoot` is a problem as it is still read-only. But I guess this is what the comment should say, because right now it looks strange.
|
Which
The README file is outside the source directory after it has been unpacked/copied over, but we can still get to it via
I've cleaned it up. Let me know what you think. |
Actually, Unpack phase copies entire
Nice, thanks. |
I must have missed something then. I'm sure I tried the |
Motivation for this change
We have been carrying the qt5 version for a long time (which works fine), so let's just drop the old qt4 variant. Also use the proper qt5
mkDerivation.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @pSub @7c6f434c