Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckb-next: fix #67371 #67495

Merged
merged 1 commit into from Aug 27, 2019
Merged

ckb-next: fix #67371 #67495

merged 1 commit into from Aug 27, 2019

Conversation

alkeryn
Copy link
Contributor

@alkeryn alkeryn commented Aug 26, 2019

Motivation for this change

see issue #67371
Basically keyboard light animation were suddenly broken after i updated the system even tho
that derivation hasn't changed, so kinda weird but that fixes it.

Things done

Just changed changed a cmakeflag

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@mmahut
Copy link
Member

mmahut commented Aug 27, 2019

@GrahamcOfBorg build ckb-next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants