Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-postgres-exporter: init at 0.5.1 #65751

Merged
merged 1 commit into from Aug 2, 2019
Merged

prometheus-postgres-exporter: init at 0.5.1 #65751

merged 1 commit into from Aug 2, 2019

Conversation

fpletz
Copy link
Member

@fpletz fpletz commented Aug 1, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @WilliButz

@fpletz fpletz requested a review from WilliButz August 1, 2019 21:23
@Ma27
Copy link
Member

Ma27 commented Aug 1, 2019

@GrahamcOfBorg test prometheus-exporters.postgres

Ma27
Ma27 approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! The diff appears to be fine, I ran the test locally and deployed the exporter to one of my machines with a postgresql service as this looks pretty interesting :)

I'd wait for an approval of @WilliButz and ofBorg to finish, but from perspective this is good to go 👍

@fpletz
Copy link
Member Author

fpletz commented Aug 2, 2019 •
edited

Added a missing description in the NixOS module and improved the test by stopping and starting PostgreSQL.

@fpletz fpletz force-pushed the pkgs/prometheus-postgres-exporter branch from 668bf86 to e4c60a1 Compare August 2, 2019 14:01
@fpletz
Copy link
Member Author

fpletz commented Aug 2, 2019

@GrahamcOfBorg test prometheus-exporters.postgres

@WilliButz WilliButz merged commit c221f9f into NixOS:master Aug 2, 2019
@WilliButz WilliButz deleted the pkgs/prometheus-postgres-exporter branch August 2, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@WilliButz WilliButz WilliButz approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fpletz @Ma27 @WilliButz