Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific error message for missing module return from 'elaborate'. #163

Closed
wants to merge 4 commits into from
Closed

Conversation

ret
Copy link
Contributor

@ret ret commented Aug 2, 2019

As a beginner, I made this mistake a few times, when I was commenting things in and out from my 'elaborate' functions. When I forgot to return a module from 'elaborate', I got the error 'AttributeError: Object 'None' cannot be elaborated.', which threw me off initially. Perhaps this can help other beginners to locate the problem quickly.

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #163 into master will decrease coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   80.74%   80.71%   -0.04%     
==========================================
  Files          32       32              
  Lines        5241     5243       +2     
  Branches     1135     1136       +1     
==========================================
  Hits         4232     4232              
- Misses        873      874       +1     
- Partials      136      137       +1
Impacted Files Coverage Δ
nmigen/hdl/ir.py 93.88% <33.33%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 995e4ad...2b373e5. Read the comment docs.

ret added 2 commits August 1, 2019 22:37

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…dated test case.
@ret
Copy link
Contributor Author

ret commented Aug 2, 2019

Squashed the two changes into one '0f2652096eb7269af36f82b7be69d313702d45b5'.

Sorry, something went wrong.

@ret
Copy link
Contributor Author

ret commented Aug 2, 2019

I'll redo this properly. Will resend a new pull request shortly.

Sorry, something went wrong.

@ret ret closed this Aug 2, 2019
@whitequark
Copy link
Contributor

Don't worry, I'll just apply this myself, it would be easier that way.

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants