bitwarden: init at 1.15.2 #65764
Merged
bitwarden: init at 1.15.2 #65764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angristan
approved these changes
Aug 2, 2019
worldofpeace
suggested changes
Aug 2, 2019
worldofpeace
reviewed
Aug 3, 2019
worldofpeace
reviewed
Aug 3, 2019
This was referenced Aug 4, 2019
|
eval failure is because |
|
this seemed to work for me @Kiwi, let my know what happens diff --git a/pkgs/tools/security/bitwarden/default.nix b/pkgs/tools/security/bitwarden/default.nix
index 189e68fe3fa..b34f238dffc 100644
--- a/pkgs/tools/security/bitwarden/default.nix
+++ b/pkgs/tools/security/bitwarden/default.nix
@@ -97,7 +97,7 @@ let
unpackPhase = "dpkg-deb -x $src .";
installPhase = ''
- mkdir -p "$out"
+ mkdir -p "$out/bin"
cp -R "opt" "$out"
cp -R "usr/share" "$out/share"
chmod -R g-w "$out"
@@ -105,12 +105,13 @@ let
# Desktop file
mkdir -p "$out/share/applications"
cp "${desktopItem}/share/applications/"* "$out/share/applications"
- '';
- postFixup = ''
- makeWrapper $out/opt/Bitwarden/bitwarden $out/bin/bitwarden \
- --prefix LD_LIBRARY_PATH : "${stdenv.lib.makeLibraryPath [ stdenv.cc.cc libsecret udev ] }"
+ ln -s $out/opt/Bitwarden/bitwarden $out/bin/bitwarden
'';
+
+ runtimeDependencies = [
+ udev.lib
+ ];
};
in if stdenv.isDarwin
|
worldofpeace
suggested changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Started using bitwarden and it's really nice so I thought I'd add the GUI (someone else asked for it already as well #51212 )
EDIT for posterity: this was fixed by packaging it differently (it does it when run with electron binary)
There's a weird thing that happens and I'm not sure if it's something I did or intentional on the developers part (I'm not sure I've done the expression right anyway) in that it launches the app with the devtools panel open. F12 and it goes away or close it. shrug If someone knows a better way to package electron apps I'd be glad for suggestions. Other than that it seems to work fine.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @