Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

framac: 18.0 -> 19.0 #65664

Closed
wants to merge 1 commit into from
Closed

framac: 18.0 -> 19.0 #65664

wants to merge 1 commit into from

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Jul 31, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice @amiddelk

@ofborg ofborg bot requested a review from thoughtpolice July 31, 2019 15:09
@mmahut
Copy link
Member

mmahut commented Aug 1, 2019

@GrahamcOfBorg build framac

thoughtpolice
thoughtpolice requested changes Aug 2, 2019
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already done by #63494, which also does more, including auto-configuration of why3 provers, and does several other nice cleanups. It was WIP until a few days ago, as the author was otherwise busy, I assume.

Apologies for taking a few days to reply to this; however I think #63494 is probably what we want to merge in the end.

@vbgl
Copy link
Contributor

vbgl commented Aug 3, 2019

Closing as #63494 has been merged.

@vbgl vbgl closed this Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yrashk @mmahut @vbgl @thoughtpolice