Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sepaxml: 2.0.0 -> 2.1.0 #65750

Merged
merged 4 commits into from Aug 7, 2019
Merged

pythonPackages.sepaxml: 2.0.0 -> 2.1.0 #65750

merged 4 commits into from Aug 7, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 1, 2019 •
edited

Motivation for this change

Noticed it was out of date. Also, enabled tests.

More work than I was expecting.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @elohmeier

$ nix build --no-link --keep-going --max-jobs 8 --option build-use-sandbox true -f /home/jon/.cache/nix-review/pr-65750-2/build.nix
https://github.com/NixOS/nixpkgs/pull/65750
6 package were build:
python27Packages.elementpath python27Packages.xmlschema python37Packages.elementpath python37Packages.fints python37Packages.sepaxml python37Packages.xmlschema

@jonringer jonringer requested a review from FRidh as a code owner August 1, 2019 20:31
@jonringer
Copy link
Contributor Author

Upstreamed fints version bounds here raphaelm/python-fints#88

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.xmlschema python3Packages.elementpath python3Packages.sepaxml python3Packages.fints

@elohmeier
Copy link
Contributor

Looks good to me, thanks @jonringer !

@risicle
Copy link
Contributor

risicle commented Aug 2, 2019 •
edited

On macos 10.13 xmlschema's automatic check to disable "remote tests" fails to detect the lack of network access and test_remote_schemas_loading fails.

You can either add this test to the -k 'not ...' clause or add to checkPhase:

substituteInPlace xmlschema/tests/__init__.py --replace "SKIP_REMOTE_TESTS = " "SKIP_REMOTE_TESTS = True #"

Not sure which is more likely to prove robust.

(Other than that, WFM on non-nixos linux x86_64 and macos 10.13)

@jonringer
Copy link
Contributor Author

Interesting, I wonder if this is from the macos environment being impure, so it's able to touch network and do the network calls. Because the logic seems sound. I'll change it, don't worry :)

@risicle
Copy link
Contributor

risicle commented Aug 2, 2019

It's something along those lines, yes.

@jonringer
Copy link
Contributor Author

@risicle can you retry macos, it was able to build for me :)

risicle
risicle approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM now.

@jonringer jonringer mentioned this pull request Aug 5, 2019
Closed
@ryantm ryantm merged commit 12c33c1 into NixOS:master Aug 7, 2019
@jonringer jonringer deleted the update-python-sepaxml branch August 8, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @elohmeier @risicle @ryantm