Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macvim: 8.1.1517 -> 8.1.1722 #65713

Merged
merged 1 commit into from Aug 17, 2019
Merged

macvim: 8.1.1517 -> 8.1.1722 #65713

merged 1 commit into from Aug 17, 2019

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented Aug 1, 2019

Motivation for this change

https://github.com/macvim-dev/macvim/releases/tag/snapshot-157

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: vim label Aug 1, 2019
@ofborg ofborg bot requested a review from cstrahan August 1, 2019 07:39
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/38

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/45

@aanderse
Copy link
Member

@GrahamcOfBorg build macvim

@lilyball
Copy link
Member Author

I'm pretty sure macvim doesn't build in the sandbox, since it uses Xcode. I haven't actually tested myself though, since I don't use the sandbox locally.

@aanderse
Copy link
Member

@lilyball ah... well in that case let me check with the person I generally ask about darwin stuff. Oh wait, that's you 🎉

@aanderse aanderse merged commit 08161d9 into NixOS:master Aug 17, 2019
@lilyball lilyball deleted the macvim branch August 17, 2019 02:09
@lilyball
Copy link
Member Author

Some day if I find myself with infinite time I'll see if I can't get macvim working using xcbuild, but our patch relies on ibtool so I'm a bit skeptical about being able to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lilyball @nixos-discourse @aanderse