Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: 1.19.1 -> 1.22.0 #65770

Merged
merged 4 commits into from Aug 4, 2019
Merged

grpc: 1.19.1 -> 1.22.0 #65770

merged 4 commits into from Aug 4, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Aug 2, 2019

Motivation for this change

fixes #65552
closes: #62428
cc: @Kaali

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor

Please update the other packages mentioned at #62428 (comment) in step with this.

@marsam
Copy link
Contributor Author

marsam commented Aug 3, 2019

@worldofpeace sorry for the delay, I've updated the packages

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to be. Haven't built the reverse dependencies to see if anything regressed.

@marsam marsam merged commit 9b12217 into NixOS:master Aug 4, 2019
@marsam marsam deleted the update-grpc branch August 4, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc does not build on macOS
2 participants