nixos/xonsh: Use the package specified in the package option #65702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently, NixOS has a
config.programs.xonsh.package
option, but it does not do anything. This patch uses the package specified in the option instead of the default xonsh with no extra options.There are still several improvements I may make over time, such as allowing xonsh to be used as a login shell or adding an option for extra Python packages, but I'm still working on those and it will have to come into a new pull request
Things done
Replace
pkgs.xonsh
withcfg.package
in NixOS's xonsh modulesandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
There don't seem to be maintainers listed in this module.