Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/xonsh: Use the package specified in the package option #65702

Merged
merged 1 commit into from Aug 1, 2019

Conversation

artemist
Copy link
Member

Motivation for this change

Currently, NixOS has a config.programs.xonsh.package option, but it does not do anything. This patch uses the package specified in the option instead of the default xonsh with no extra options.

There are still several improvements I may make over time, such as allowing xonsh to be used as a login shell or adding an option for extra Python packages, but I'm still working on those and it will have to come into a new pull request

Things done

Replace pkgs.xonsh with cfg.package in NixOS's xonsh module

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

There don't seem to be maintainers listed in this module.

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @artemist!

@aanderse aanderse merged commit f03639a into NixOS:master Aug 1, 2019
@artemist artemist deleted the xonsh-module-fix branch August 1, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants