Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyqt5: upgrade and solve qml issue #65836

Merged
merged 8 commits into from Aug 3, 2019
Merged

pythonPackages.pyqt5: upgrade and solve qml issue #65836

merged 8 commits into from Aug 3, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Aug 3, 2019 •
edited

Motivation for this change

This PR upgrades .pyqt5 and .pyqtwebengine and fixes their build. During build-time many Qt modules were not detected and thus not included in the build. Apparently they also need to be added to nativeBuildInputs. I suppose this is because of qmake?

Anyway, both packages work fine when using with python3.withPackages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

This was referenced Aug 3, 2019
Closed
Closed
@FRidh
Copy link
Member Author

FRidh commented Aug 3, 2019

Qutebrowser now runs without the error. However, there is a regression in PyQt5.sip for Python 2 it seems.

@FRidh
Copy link
Member Author

FRidh commented Aug 3, 2019

I can imagine we can have collisions with sip as well because for each variant we create sipconfig.py at the same location.

Robert Schütz and others added 6 commits August 3, 2019 14:19
@FRidh
python.pkgs.pyqt5: 5.11.3 -> 5.13.0
0aef71a 
This upgrades pyqt5 and fixes the build. Note that the QtWebEngine
module is split into `pyqtwebengine` by upstream and us.

If your application gives an error that a Qt module is missing, then
that is most likely because it was not included when building pyqt5.
The solution is to simply add it here to the `(native)BuildInputs`.
Don't forget to add an import check. We should include all the modules
(except qtwebkit) that are needed.
@FRidh
python.pkgs.pyqtwebengine: init at 5.12.1
213e4e6 
5.13.0 is available, however, it assumes qt 5.13 is used and fails
to build due to a missing QWebEngineNotification class.
@FRidh
qutebrowser: add pyqtwebengine to propagatedBuildInputs
41fb928
@FRidh
pythonPackages.spyder-kernels: 0.4.4 -> 0.5.1
40d5c09
@FRidh
pythonPackages.spyder: 3.3.4 -> 3.3.6 and fix with pyqt5 5.13
6d53587
@FRidh
anki: fix with pyqtwebengine
abfe7f0
@FRidh
Copy link
Member Author

FRidh commented Aug 3, 2019 •
edited

qgis and calibre don't build yet, but I leave that for someone else (or at least another day).

This was referenced Aug 3, 2019
Closed
Closed
Closed
Closed
@FRidh
Copy link
Member Author

FRidh commented Aug 3, 2019

@GrahamcOfBorg build picard qutebrowser anki python3Packages.spyder

@ghost
Copy link

ghost commented Aug 3, 2019

Great news that this is finally figured out 🎉
I built and ran qutebrowser successfully, so that's good
I am wondering if adding the target dependencies to nativeBuildInputs really is the right thing, it detected qml just fine before, so what broke it?

@FRidh
Copy link
Member Author

FRidh commented Aug 3, 2019

I am wondering if adding the target dependencies to nativeBuildInputs really is the right thing, it detected qml just fine before, so what broke it?

Yes, I don't like it either. Maybe strictDeps = true;? I have not checked it.

@FRidh FRidh merged commit 33a876e into NixOS:master Aug 3, 2019
@FRidh FRidh deleted the pyqt branch August 3, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagajaga jagajaga Awaiting requested review from jagajaga

@svanderburg svanderburg Awaiting requested review from svanderburg

@lovek323 lovek323 Awaiting requested review from lovek323

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@gebner gebner Awaiting requested review from gebner

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FRidh