Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yubioath-desktop: use qt wrapped mkDerivation #65838

Merged
merged 1 commit into from Aug 4, 2019
Merged

yubioath-desktop: use qt wrapped mkDerivation #65838

merged 1 commit into from Aug 4, 2019

Conversation

terlar
Copy link
Contributor

@terlar terlar commented Aug 3, 2019 •
edited

Motivation for this change

yubioath-desktop is currently broken due to recent changes with the QT setup in nix and not using the QT wrapper as per the guidelines.

Things done

Using the mkDerivation wrapper for QT apps.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92

@terlar terlar force-pushed the feature/gtwrap-yubioath-desktop branch from a2574ab to 2527a5c Compare August 3, 2019 11:11
@ofborg ofborg bot requested a review from Mic92 August 3, 2019 11:24
@terlar
Copy link
Contributor Author

terlar commented Aug 3, 2019

cc #65399

@teto teto merged commit 55565b0 into NixOS:master Aug 4, 2019
@teto
Copy link
Member

teto commented Aug 4, 2019

ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@terlar @teto