Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins: update #65834

Merged
merged 1 commit into from Aug 3, 2019
Merged

vimPlugins: update #65834

merged 1 commit into from Aug 3, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Aug 3, 2019 •
edited

Motivation for this change

Regular update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Aug 3, 2019

couldn't this be run as a daliy job instead ?

@timokau
Copy link
Member Author

timokau commented Aug 3, 2019

It could, if someone would build the infrastructure and review the PRs daily. Currently the "infrastructure" is a weekly recurring entry in my todo list.

@timokau timokau merged commit 48a72e1 into NixOS:master Aug 3, 2019
@timokau timokau deleted the vimPlugins-2019-08-03 branch August 3, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @teto