Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libextractor: add support for gstreamer plugin #65835

Merged
merged 1 commit into from Apr 29, 2020
Merged

libextractor: add support for gstreamer plugin #65835

merged 1 commit into from Apr 29, 2020

Conversation

jorsn
Copy link
Member

@jorsn jorsn commented Aug 3, 2019 •
edited

Motivation for this change

The gstreamer plugin provides support for additional common
file/tagging formats like id3 tags in mp3 files. In addition, it
e.g. exposes more tags than the FLAC plugin for FLAC files.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip" (last successful run on 2020-04-28)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size: 86.71 MB (52.8%)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    (apart from having no maintainer as before this change)
Notify maintainers

package has no maintainer

Questions

The impact on the package closure size is quite substantial. Should gstreamerSupport be false by default? I'll leave it true but added a comment about it.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/15

@jtojnar
Copy link
Contributor

jtojnar commented Dec 1, 2019 •
edited

This will only have an effect on the binary, not the library. The codecs will need to be provided through a patch like in #57619. See https://nixos.org/nixpkgs/manual/#sec-language-gnome for more information.

@jorsn
Copy link
Member Author

jorsn commented Apr 28, 2020

I pushed only a comment about the package closure size so people needing a small closure know how to cut the size down.

I also successfully ran nix-shell -p nix-review --run "nix-review wip" again.
@jtojnar, @doronbehar Would you mind posting this PR in that discourse thread?

@doronbehar
Copy link
Contributor

Usually it's the PR writer posting there :). @jtojnar has merge permissions so let's hope he'll do it.

@jorsn
Copy link
Member Author

jorsn commented Apr 28, 2020

Usually it's the PR writer posting there :)

According to the top post it's the reviewers, so that committers know te PR is approved and don't have to think about it.

@jorsn
libextractor: add support for gstreamer plugin
555b8c1 
The gstreamer plugin provides support for additional common
file/tagging formats like id3 tags in mp3 files. In addition, it
e.g. exposes more tags than the FLAC plugin for FLAC files.

Increase of closure size: 86.71 MB (52.8%)
@jtojnar jtojnar merged commit 519b7d2 into NixOS:master Apr 29, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Apr 29, 2020

Thanks.

@jorsn jorsn deleted the libextractor-gstreamer branch March 1, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@doronbehar doronbehar doronbehar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jorsn @nixos-discourse @jtojnar @doronbehar