New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocrmypdf: init #65775
ocrmypdf: init #65775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's just an application, then it needs to be moved out of python-packages.nix
.
pkgs/development/python-modules/pytest-helpers-namespace/default.nix
Outdated
Show resolved
Hide resolved
ce3d50b
to
76954bd
Compare
pkgs/development/python-modules/pytest-helpers-namespace/default.nix
Outdated
Show resolved
Hide resolved
pytestrunner | ||
python-xmp-toolkit | ||
setuptools | ||
] ++ runtimeDeps; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runTimeDeps
is already added to propagatedBuildInputs
, so no need to add here again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed it there. I had to add it to checkInputs to make the tests work when they are enabled. Is that expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If those are only needed for tests, then yes. If they are needed when using this program, then they should be added to (propagated)(buildInputs)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's the former. It seems to work how it is now. The only thing I know about at this point is I haven't ever been able to get it this version to work in nix-review but it seems to work when installed. Not sure if that's an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Action needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
5664a60
to
97b3923
Compare
I like your optimism and thank you for all of the feedback! |
pkgs/development/python-modules/pytest-helpers-namespace/default.nix
Outdated
Show resolved
Hide resolved
|
||
src = fetchFromGitHub { | ||
owner = "tmbdev"; | ||
repo = "${pname}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repo = "${pname}"; | |
repo = pname; |
|
||
meta = with stdenv.lib; { | ||
description = " | ||
Tools for manipulating and evaluating the hOCR format for representing multi-lingual OCR results by embedding them into HTML"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this shorter?
|
||
src = fetchFromGitHub { | ||
owner = "saltstack"; | ||
repo = "${pname}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repo = "${pname}"; | |
repo = pname; |
# It includes the commits for the unreleased version 2.0.2 and more | ||
# Tests pass with this version | ||
src = fetchFromGitHub { | ||
owner = "python-xmp-toolkit"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
owner = "python-xmp-toolkit"; | |
owner = pname; |
# Tests pass with this version | ||
src = fetchFromGitHub { | ||
owner = "python-xmp-toolkit"; | ||
repo = "python-xmp-toolkit"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repo = "python-xmp-toolkit"; | |
repo = pname; |
|
||
src = fetchFromGitHub { | ||
owner = "cgat-developers"; | ||
repo = "${pname}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repo = "${pname}"; | |
repo = pname; |
pytest | ||
]; | ||
|
||
checkPhase = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work?
checkPhase = null;
preCheck = ''
export HOME=$TMPDIR
'';
makefile = "ruffus/test/MakeFile"
checkTarget = "all"
checkFlags = [
"PYTEST_OPTIONS='-q --disable-warnings'"
];
we don't cd
because of setting makefile
pytestrunner | ||
python-xmp-toolkit | ||
setuptools | ||
] ++ runtimeDeps; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Action needed here?
I've merged it despite requesting further changes. After a week or so of making changes I think it is "good enough". |
Motivation for this change
Many people have tried to package this... most have failed. I myself have spent months working on it and a while sitting on it. This is the best I've come up with and the newest version I've been able to make work. I want to get something submitted and feedback before I try again on the newer releases. It works to the extent that I've used it (minimally). Some tests are disabled because of course python has a lot of problems especially on nixos... and they take an excruciatingly long time to run anyway. But most of them pass when you do.
Things done
Added OCRmyPDF and a few dependencies.
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @