Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoom-us: use flathub desktop integration #65704

Merged
merged 2 commits into from Aug 1, 2019
Merged

zoom-us: use flathub desktop integration #65704

merged 2 commits into from Aug 1, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fixes #65678

Things done

Successfully launched zoom-us with the new desktop file.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from danbst August 1, 2019 01:54
tadfisher
tadfisher approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@tadfisher tadfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@worldofpeace worldofpeace merged commit 299c2f0 into NixOS:master Aug 1, 2019
@worldofpeace worldofpeace deleted the zoom-us-desktopmetadata branch August 1, 2019 18:57
aske pushed a commit to aske/nixpkgs that referenced this pull request Aug 4, 2019
@worldofpeace @aske
Merge pull request NixOS#65704 from worldofpeace/zoom-us-desktopmetadata
cb1f648 
zoom-us: use flathub desktop integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@tadfisher tadfisher tadfisher approved these changes

@danbst danbst Awaiting requested review from danbst

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zoom-us: Missing desktop icon
3 participants
@worldofpeace @matthewbauer @tadfisher