Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runwayml: init at 0.8.1 #65782

Merged
merged 1 commit into from Aug 7, 2019
Merged

runwayml: init at 0.8.1 #65782

merged 1 commit into from Aug 7, 2019

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Aug 2, 2019 •
edited

Motivation for this change

RunwayML is a machine learning tool for creators.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@prusnak prusnak force-pushed the runway branch 2 times, most recently from 95988d1 to 72d4866 Compare August 2, 2019 20:41
@prusnak prusnak changed the title runwayml: init at 0.8.0 runwayml: init at 0.8.1 Aug 2, 2019
mmahut
mmahut approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg evals
  • run nix-review without any failures
  • run and tested the binaries

@mmahut mmahut merged commit abe1af1 into NixOS:master Aug 7, 2019
@prusnak prusnak deleted the runway branch August 7, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @mmahut