Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yubikey-personalization-gui: use qt wrapped mkDerivation #65840

Merged
merged 1 commit into from Aug 3, 2019
Merged

yubikey-personalization-gui: use qt wrapped mkDerivation #65840

merged 1 commit into from Aug 3, 2019

Conversation

terlar
Copy link
Contributor

@terlar terlar commented Aug 3, 2019

Motivation for this change

yubikey-personalization-gui is currently broken due to not using the new QT guidelines.

Things done

Using the new mkDerivation wrapper for QT apps.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

None

@worldofpeace
Copy link
Contributor

yubikey-personalization-gui is currently broken due to not using the new QT guidelines.

It's actually because it wasn't using qt's mkDerivation possibly on inclusion in nixpkgs.
And that part of the documentation hasn't changed.

worldofpeace
worldofpeace approved these changes Aug 3, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Launches for me 👍

@worldofpeace
Copy link
Contributor

cc #65399

@worldofpeace worldofpeace merged commit d0f088d into NixOS:master Aug 3, 2019
@terlar
Copy link
Contributor Author

terlar commented Aug 3, 2019

I see, those were always the guidelines and it kind of worked by accident. But with the new changes that is not the case anymore. Thank you for the clarification, I haven't looked into the details of the recent "qt-breakage".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@terlar @worldofpeace