Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/xdg/portal: set GTK_USE_PORTAL with lib.mkIf #65754

Merged
merged 1 commit into from Aug 1, 2019
Merged

nixos/xdg/portal: set GTK_USE_PORTAL with lib.mkIf #65754

merged 1 commit into from Aug 1, 2019

Conversation

worldofpeace
Copy link
Contributor

If lib.optional is given a false value it will return an empty list.
Thusly the set-environment script can have

export GTK_USE_PORTAL=

This can rub certain bugs the wrong way #65679
so lets make sure this isn't set in the environment
at all.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
nixos/xdg/portal: set GTK_USE_PORTAL with lib.mkIf
64b4a24 
If lib.optional is given a false value it will return an empty list.
Thusly the set-environment script can have

```
export GTK_USE_PORTAL=
```

This can rub certain bugs the wrong way NixOS#65679
so lets make sure this isn't set in the environment
at all.
@worldofpeace worldofpeace merged commit ce21e1c into NixOS:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace