Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add options for build idris package #65666

Merged
merged 2 commits into from Aug 7, 2019
Merged

add options for build idris package #65666

merged 2 commits into from Aug 7, 2019

Conversation

marcosh
Copy link
Contributor

@marcosh marcosh commented Jul 31, 2019

Motivation for this change

It could be helpful to provide additional options to idris commands while building, testing and install an idris package.

For my specific use case, I need to add a --log option to idris commands.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ x ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ x ] Ensured that relevant documentation is up to date
  • [ x ] Fits CONTRIBUTING.md.

@marcosh marcosh requested a review from infinisil as a code owner July 31, 2019 15:15
@marcosh marcosh mentioned this pull request Jul 31, 2019
Closed
@infinisil
Copy link
Member

It might be better (though less convenient) to pass options as a list of strings instead of a string directly, such that users don't need to worry about proper escaping (can be done in the code with lib.escapeShellArgs).

@marcosh
Copy link
Contributor Author

marcosh commented Aug 1, 2019

@infinisil that seems like a nice suggestion. I updated the code and the docs accordingly

@infinisil
Copy link
Member

Could you squash the last commit into the first two? This looks good to merge otherwise

@marcosh
Copy link
Contributor Author

marcosh commented Aug 6, 2019

done! Thanks @infinisil for your feedback!

@infinisil infinisil merged commit dd7de2d into NixOS:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcosh @infinisil @Janik-Haag