Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wavpack: CVE-2019-1010317 CVE-2019-1010319 #65668

Merged
merged 2 commits into from Aug 10, 2019
Merged

wavpack: CVE-2019-1010317 CVE-2019-1010319 #65668

merged 2 commits into from Aug 10, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 31, 2019 •
edited

Motivation for this change

Fixes #65655

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @codyopel

@risicle
Copy link
Contributor

risicle commented Aug 3, 2019

nox-review checks out for me on macos 10.13 (except gst-plugins-good which wasn't building for me in the first place)

@risicle
Copy link
Contributor

risicle commented Aug 4, 2019

It also builds fine on non-nixos linux x86_64 and the binaries work (no time for nox-review here I'm afraid)

vcunat added a commit that referenced this pull request Aug 10, 2019
@vcunat
Merge #65668: wavpack: CVE-2019-1010317 CVE-2019-1010319
c6bbd52 
(cherry picked from commit 6c177c3)
@vcunat vcunat merged commit 87d5ec4 into NixOS:master Aug 10, 2019
vcunat added a commit that referenced this pull request Aug 10, 2019
@vcunat
Merge #65668: wavpack: CVE-2019-1010317 CVE-2019-1010319
6c177c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 73: wavpack-5.1.0: 3 advisories
4 participants
@mmahut @risicle @vcunat @veprbl