Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solargraph: 0.34.2 -> 0.35.1 #65719

Merged
merged 3 commits into from Aug 1, 2019
Merged

solargraph: 0.34.2 -> 0.35.1 #65719

merged 3 commits into from Aug 1, 2019

Conversation

angristan
Copy link
Member

@angristan angristan commented Aug 1, 2019 •
edited

Motivation for this change

New solargraph release: https://github.com/castwide/solargraph/releases

Things done
nix-shell -p bundler git --run 'bundle lock --update'
nix-shell -p bundix git --run 'bundix'
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace @nicknovitski

@ofborg ofborg bot added the 6.topic: ruby label Aug 1, 2019
@angristan
Copy link
Member Author

I took the liberty of adding myself as a maintainer since I made the last 3 updates 🙂

@ofborg ofborg bot requested a review from worldofpeace August 1, 2019 12:26
@worldofpeace
Copy link
Contributor

@angristan Can you prefix the last commit with the attribute solargraph.
Also, it's probably not a good idea to @ yourself in the commit because you might get many more pings than you expected. (people's forks even).

@nicknovitski
Copy link
Contributor

I took the liberty of adding myself as a maintainer since I made the last 3 updates 🙂

In the future you can run nix-shell maintainers/scripts/update.nix --argstr package solargraph, or after becoming the maintainer --argstr maintainer angristan.

@worldofpeace
Copy link
Contributor

@angristan Can you prefix the last commit with the attribute solargraph.
Also, it's probably not a good idea to @ yourself in the commit because you might get many more pings than you expected. (people's forks even).

Wait. Actually this should be that adding yourself to the maintainers list should be a commit on its own, and adding yourself as a maintainer to solargraph should be as well.

@angristan
Copy link
Member Author

Should be good now!

@worldofpeace worldofpeace merged commit ac0d7ef into NixOS:master Aug 1, 2019
@worldofpeace
Copy link
Contributor

Thanks @angristan

@angristan
Copy link
Member Author

Thanks @worldofpeace @nicknovitski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais

@zimbatm zimbatm Awaiting requested review from zimbatm

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@angristan @worldofpeace @nicknovitski