Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gildas: 20190701_a -> 20190901_a #65726

Merged
merged 1 commit into from Sep 6, 2019
Merged

Conversation

smaret
Copy link
Member

@smaret smaret commented Aug 1, 2019

Motivation for this change

Update Gildas to the latest upstream version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@smaret
Copy link
Member Author

smaret commented Aug 2, 2019

This builds on Linux, but on Darwin I get the following error:

gildas-src-aug19a/integ/x86_64-darwin-gfortran-openmp/bin/hlp2tex \
      -L/private/var/folders/r2/zwnv7zsd4bd99mqkn4mhqxn800034l/T/nix-build-gildas-20190801_a.drv-0/gildas-src-aug19a/integ/x86_64-darwin-gfortran-openmp/lib -L/nix/store/7nrhz57r0h1g4avg0ba9m2n8asfwdb61-python-2.7.16/lib   -L/nix/store/d0xg488j5iw4z5zd19cp8a1mjgcjg50n-gtk+-2.24.32/lib -L/nix/store/w9fnipb9ficaz1iv1fryl1pvhvmq9zvc-glib-2.60.4/lib -L/nix/store/gclh8scc9wffh1drbx73yamaksiyrl2z-cairo-1.16.0/lib -L/nix/store/9vkdlyk2nwz2rh7i88881bgp8px5v398-fontconfig-2.12.6-lib/lib -L/nix/store/vwdvgl2dcxyw14plyz9p4517i39m7381-freetype-2.10.0/lib -L/nix/store/sdxb2xv1i7a1vvjmqpcx6rrj1xc5sv3k-pango-1.43.0/lib -L/nix/store/vk2fjbcc34ccr91wqq2hglaymy4x5ixl-gdk-pixbuf-2.38.1/lib -L/nix/store/9789bxxhv5dcs23yiqfgifk8864c026j-atk-2.32.0/lib -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lfontconfig -lfreetype -lgthread-2.0 -lglib-2.0 -L/nix/store/vvgvamfcrrkj4p57ff1krxnl8l6z5hc3-libpng-apng-1.6.37/lib -lpng16  -L/nix/store/7nrhz57r0h1g4avg0ba9m2n8asfwdb61-python-2.7.16/lib -ldl -framework CoreFoundation -lpython2.7 -L/nix/store/n3r2h80x5n0204vkvkhklpjj6gs4pljr-cfitsio-3.47/lib -L/nix/store/af9phazy6dmyy7zzcxf1rrzadgwgplc7-bzip2-1.0.6.0.1/lib -lcfitsio -lbz2  -lm -ldl
f951: Warning: unrecognized command line option '-Wno-unused-command-line-argument'
ld: framework not found CoreFoundation

@smaret
Copy link
Member Author

smaret commented Sep 3, 2019

After some investigations, I've found that the configuration script for gildas calls python-config --libs, which returns: -lpython2.7 -ldl -framework CoreFoundation. This fails because ld does not look for frameworks in the standard locations.

@smaret smaret changed the title [WIP] gildas: 20190701_a -> 20190801_a gildas: 20190701_a -> 20190901_a Sep 5, 2019
@smaret
Copy link
Member Author

smaret commented Sep 5, 2019

Built and tested successfully on Darwin and Linux with nix review.

@smaret smaret marked this pull request as ready for review September 5, 2019 11:42
Copy link
Contributor

@bzizou bzizou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully built under NixOS, started all the binaries (some are opening windows, others are failing because there's no input I guess, so I think that it's okay)

@veprbl
Copy link
Member

veprbl commented Sep 5, 2019

@GrahamcOfBorg build gildas

@smaret
Copy link
Member Author

smaret commented Sep 5, 2019

Ofborg build on Linux fails because of an internal compiler error:

gfortran: internal compiler error: Killed (program f951)
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://gcc.gnu.org/bugs/> for instructions.

I'm not sure why this fails on OfBorg but not on both local installations of NixOs Debian?

@bzizou
Copy link
Contributor

bzizou commented Sep 6, 2019

I tested the build on:

  • NixOS with sandboxing
  • Nix under Debian
    Both build successfully...

@smaret
Copy link
Member Author

smaret commented Sep 6, 2019

I tested the build on:

  • NixOS with sandboxing
  • Nix under Debian
    Both build successfully...

Yes, it looks like an issue with gfortran on OfBorg. I suppose we can just ignore it, since the package builds fine on all platforms.

@veprbl
Copy link
Member

veprbl commented Sep 6, 2019

It might be just running out of memory.

@veprbl veprbl merged commit d6264f9 into NixOS:master Sep 6, 2019
@smaret smaret deleted the gildas-20190801_a branch September 6, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants