Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim-qt: 0.2.11 -> 0.2.12 #65762

Merged
merged 1 commit into from Aug 5, 2019
Merged

neovim-qt: 0.2.11 -> 0.2.12 #65762

merged 1 commit into from Aug 5, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Minor update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

teto
teto reviewed Aug 2, 2019
View reviewed changes
pkgs/applications/editors/neovim/qt.nix Outdated
@@ -4,13 +4,13 @@
let
unwrapped = stdenv.mkDerivation rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this follow the recommendation from #65399 and use the mkDerivation from qt rather than from stdenv ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@teto
Copy link
Member

teto commented Aug 2, 2019

ran a nix-review and it worked. Waiting for input on my other comment though,

@teto teto merged commit 0b9b95d into NixOS:master Aug 5, 2019
@teto
Copy link
Member

teto commented Aug 5, 2019

thanks

@peterhoeg peterhoeg deleted the u/nvim-qt branch August 5, 2019 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @teto