Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frog: Fix build (icu64 -> icu60) #65677

Merged
merged 1 commit into from Aug 1, 2019
Merged

frog: Fix build (icu64 -> icu60) #65677

merged 1 commit into from Aug 1, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

Build was failing.

icu60 is the latest version that works.

Build the derivation languageMachines.test to test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @roberth

@JohnAZoidberg
frog: Fix build (icu64 -> icu60)
851ebff 
icu60 is the latest version that works.

Build the derivation languageMachines.test to test.
@JohnAZoidberg
Copy link
Member Author

@GrahamcOfBorg build languageMachines.test

@roberth roberth merged commit 2bd9aac into NixOS:master Aug 1, 2019
@JohnAZoidberg JohnAZoidberg deleted the fix-frog branch August 1, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth roberth approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JohnAZoidberg @roberth