Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.shamir-mnemonic: init at 0.1.0 #65682

Closed
wants to merge 1 commit into from
Closed

pythonPackages.shamir-mnemonic: init at 0.1.0 #65682

wants to merge 1 commit into from

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Jul 31, 2019

Motivation for this change

This package is needed in order to upgrade pythonPackages.trezor as it's its new depedency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mmahut

@1000101 1000101 requested a review from FRidh as a code owner July 31, 2019 17:49
@1000101 1000101 closed this Jul 31, 2019
@jb55
Copy link
Contributor

jb55 commented Aug 10, 2019

Why close? Was looking for this today..

@mmahut
Copy link
Member

mmahut commented Aug 10, 2019

@jb55 check out #65683.

@jb55
Copy link
Contributor

jb55 commented Aug 10, 2019

@mmahut thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@1000101 @jb55 @mmahut