Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHCP: is setting address before ACKed ok? #302

Closed
birkenfeld opened this issue Aug 1, 2019 · 0 comments · Fixed by #310
Closed

DHCP: is setting address before ACKed ok? #302

birkenfeld opened this issue Aug 1, 2019 · 0 comments · Fixed by #310

Comments

@birkenfeld
Copy link

Migrating my project to the now merged version of the DHCP client, I noticed that the IP address of the interface has to be set to the OFFERed address before the client will send out a proper REQUEST. I feel like this is racy, and the "official" IP of the interface should only be set once the server has ACKed the request.

The client is already tracking state information in its state enum (which btw I think should be available publicly, or at least as a discriminant-only Discovering/Requesting/Renew), so the last offered IP could also go there?

/cc @astro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants