[Import Maps] Update resolving tests from upstream #18264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 3, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1734024
branch
2 times, most recently
from
81b5f12
to
c05ac61
Compare
This CL imports more tests from upstream: - Test files from https://github.com/WICG/import-maps/tree/master/reference-implementation/__tests__ are imported to import-maps/imported/resources/. - Generated test HTMLs are placed in import-maps/imported/. - To support more tests, the glue code in resolving.tentative.html is moved into `jest-test-helper.js` and extended to support new tests. The current test failures are added as -expected.txt, and will be fixed in the future when import map functionalities are implemented or fixed. Bug: 990561 Change-Id: I087df82355513584a0cf1891da648dd2155f53c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734024 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#686701}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1734024
branch
from
c05ac61
to
826defb
Compare
|
Appears GitHub is stripping "__" from end of the URL. |
|
Using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL imports more tests from upstream:
https://github.com/WICG/import-maps/tree/master/reference-implementation/__tests__
are imported to import-maps/imported/resources/.
is moved into
jest-test-helper.jsand extended to support new tests.The current test failures are added as -expected.txt, and will be
fixed in the future when import map functionalities are implemented or fixed.
Bug: 990561
Change-Id: I087df82355513584a0cf1891da648dd2155f53c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734024
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686701}