Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.03] doc: fix passthru.updateScript help command #65790

Merged
merged 1 commit into from Aug 3, 2019

Conversation

davidak
Copy link
Member

@davidak davidak commented Aug 2, 2019

Motivation for this change

Currently, the doc looks like this:

Screenshot from 2019-08-02 15-58-33

When i execute that, i get an error:

Screenshot from 2019-08-02 15-59-55

But there is a fix in master. So i backported it.

Things done

I build the manual as described in the docs.

The results looks completely different than the online doc.

Screenshot from 2019-08-02 16-01-59

I think it should be fine, but i see again that contributing to the manual is annoying and inefficient.

It took me 17 minutes to check after making the commit!

Notify maintainers

cc @

@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 3, 2019

LGTM, can you use cherry-pick -xe per the docs?

https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches

Also updated the PR title for clarity.

@worldofpeace worldofpeace added the 8.has: port to stable A PR already has a backport to the stable release. label Aug 3, 2019
@worldofpeace worldofpeace changed the title Backport Doc fix to stable [19.03] doc: fix passthru.updateScript help command Aug 3, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Aug 3, 2019

Yeah, docs writing UX is something we still need to polish a bit.

(cherry picked from commit d18f4bfb53a930f03897f5e3701181f0745df99a)
Reason: Should be fixed in stable too.
@davidak
Copy link
Member Author

davidak commented Aug 3, 2019

can you use cherry-pick -xe per the docs?

sure. done

Yeah, docs writing UX is something we still need to polish a bit.

The current discussion seem to be here: https://discourse.nixos.org/t/documentation-improvements/3111

@Mic92 Mic92 merged commit 93ea6db into NixOS:release-19.03 Aug 3, 2019
@davidak davidak deleted the doc branch August 3, 2019 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants