Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.runway-python: init at 0.3.2 #65696

Merged
merged 2 commits into from Aug 8, 2019
Merged

pythonPackages.runway-python: init at 0.3.2 #65696

merged 2 commits into from Aug 8, 2019

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jul 31, 2019 •
edited

This commit adds new package runway-python which is a Runway Model SDK allowing you to port new and existing machine learning models to the Runway platform, more info at https://pypi.org/project/runway-python/

The commit also adds wget python package as its dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@prusnak prusnak requested a review from FRidh as a code owner July 31, 2019 21:38
@prusnak prusnak force-pushed the runwayml branch 2 times, most recently from 4d34dab to 249909f Compare August 2, 2019 16:42
@prusnak prusnak changed the title pythonPackages.runway-python: init at 0.3.1 pythonPackages.runway-python: init at 0.3.2 Aug 2, 2019
@prusnak prusnak mentioned this pull request Aug 7, 2019
Closed
10 tasks
@mmahut
Copy link
Member

mmahut commented Aug 7, 2019

@GrahamcOfBorg build pythonPackages.runway-python pythonPackages.wget python3Packages.runway-python python3Packages.wget

@mmahut
Copy link
Member

mmahut commented Aug 7, 2019 •
edited

@marsam Mario, do you mind glancing at this darwin build error? The documentation says it supports darwin, after quick chat w/ @worldofpeace we think it might be a regression.

The failed build is at https://logs.nix.ci/?key=nixos/nixpkgs.65696&attempt_id=66e99441-4b95-449d-888b-eefdb6ca45ae for python3.7-runway-python.


==================================== ERRORS ====================================
__________________ ERROR collecting tests/test_pytest_mpl.py ___________________
tests/test_pytest_mpl.py:8: in <module>
    import matplotlib.pyplot as plt
/nix/store/adndhy42521sk90w8kkc03vjq3wxxffq-python2.7-matplotlib-2.2.3/lib/python2.7/site-packages/matplotlib/pyplot.py:115: in <module>
    _backend_mod, new_figure_manager, draw_if_interactive, _show = pylab_setup()
/nix/store/adndhy42521sk90w8kkc03vjq3wxxffq-python2.7-matplotlib-2.2.3/lib/python2.7/site-packages/matplotlib/backends/__init__.py:62: in pylab_setup
    [backend_name], 0)
/nix/store/adndhy42521sk90w8kkc03vjq3wxxffq-python2.7-matplotlib-2.2.3/lib/python2.7/site-packages/matplotlib/backends/backend_macosx.py:17: in <module>
    from matplotlib.backends import _macosx
E   RuntimeError: Python is not installed as a framework. The Mac OS X backend will not be able to function correctly if Python is not installed as a framework. See the Python documentation for more information on installing Python as a framework on Mac OS X. Please either reinstall Python as a framework, or try one of the other backends. If you are using (Ana)Conda please install python.app and replace the use of 'python' with 'pythonw'. See 'Working with Matplotlib on OSX' in the Matplotlib FAQ for more information.
------------------------------- Captured stderr --------------------------------
_RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 2.49 seconds ============================

Runtime import error is at https://github.com/matplotlib/matplotlib/blob/652478d0148187b5a2e2cb1adfa93f62be97b57f/src/_macosx.m for function verify_framework.

@marsam marsam mentioned this pull request Aug 7, 2019
Merged
10 tasks
@marsam
Copy link
Contributor

marsam commented Aug 8, 2019

@mmahut it was an issue with mathplotlib, fixed in #66304

@mmahut
Copy link
Member

mmahut commented Aug 8, 2019

@marsam thank you!

@GrahamcOfBorg build pythonPackages.runway-python pythonPackages.wget python3Packages.runway-python python3Packages.wget

@mmahut mmahut merged commit b9d100b into NixOS:master Aug 8, 2019
@prusnak prusnak deleted the runwayml branch August 8, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @mmahut @marsam