Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chefdk: 2.4.17 -> 4.2.0 #65693

Closed
wants to merge 1 commit into from
Closed

chefdk: 2.4.17 -> 4.2.0 #65693

wants to merge 1 commit into from

Conversation

nicknovitski
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @offlinehacker

@ofborg ofborg bot requested a review from offlinehacker July 31, 2019 21:32
@mmahut
Copy link
Member

mmahut commented Aug 1, 2019

@GrahamcOfBorg build chefdk

@mmahut
Copy link
Member

mmahut commented Aug 9, 2019

Failure on aarch64-linux.

unf/table.hh:13539:25: error: narrowing conversion of '-89' from 'int' to 'char' inside { } [-Wnarrowing]
unf/table.hh:13539:25: error: narrowing conversion of '-104' from 'int' to 'char' inside { } [-Wnarrowing]
unf/table.hh:13539:25: error: narrowing conversion of '-25' from 'int' to 'char' inside { } [-Wnarrowing]
unf/table.hh:13539:25: error: narrowing conversion of '-82' from 'int' to 'char' inside { } [-Wnarrowing]

@offlinehacker
Copy link
Contributor

It seems like a dependant package for aarch64, I would still merge, and someone can fix later if needed. Optionally we can remove from supported systems.

@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

Please either fix it or disable aarch64, we cannot merge changes that will produce build failures.

@nlewo
Copy link
Member

nlewo commented Feb 29, 2020

Superseded by #80858

@nlewo nlewo closed this Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker offlinehacker approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicknovitski @mmahut @offlinehacker @nlewo