Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundlerApp: meta.platforms defaults to platforms of ruby dependency #65697

Merged
merged 1 commit into from Aug 1, 2019

Conversation

nicknovitski
Copy link
Contributor

Motivation for this change

bundlerEnv does this, and it seems like a good default. Packages that work on fewer platforms can explicitly pass a more restrictive set.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lilyball

@lilyball
Copy link
Member

lilyball commented Aug 1, 2019

Seems like a good idea to me

@zimbatm zimbatm merged commit ec3f7e3 into NixOS:master Aug 1, 2019
@zimbatm
Copy link
Member

zimbatm commented Aug 1, 2019

thanks. I'm surprised this hadn't been done before already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants