Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ripgrep-all: init at 0.9.2 #65695

Merged
merged 1 commit into from
Aug 7, 2019
Merged

ripgrep-all: init at 0.9.2 #65695

merged 1 commit into from
Aug 7, 2019
+43 −0

Conversation

zaninime
Copy link
Contributor

@zaninime zaninime commented Jul 31, 2019 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

N/A

Sorry, something went wrong.

@zaninime zaninime changed the title rga: init at 0.9.2 ripgrep-all: init at 0.9.2 Jul 31, 2019
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 31, 2019
@zaninime
Copy link
Contributor Author

zaninime commented Aug 1, 2019

@mmahut anything else concerning this PR? Can we merge it?

@Mic92
Copy link
Member

Mic92 commented Aug 1, 2019

@GrahamcOfBorg build ripgrep-all

@Mic92
Copy link
Member

Mic92 commented Aug 1, 2019

Needs the Security framework on macOS: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/version-management/git-and-tools/git-absorb/default.nix#L14

@ivan
Copy link
Member

ivan commented Aug 2, 2019

I tested this on x86_64 NixOS and it worked fine.

Should this be in pkgs/tools/text like ripgrep, instead of pkgs/tools/misc? In the end, it's still searching text.

@zaninime
Copy link
Contributor Author

zaninime commented Aug 3, 2019

@Mic92 fixed and tested on a Mac.

@ivan I don't mind moving it. Let's just come to a decision on this.

@grahamc
Copy link
Member

grahamc commented Aug 4, 2019

Please move this to be in the same tree as ripgrep.

@zaninime
Copy link
Contributor Author

zaninime commented Aug 7, 2019

@grahamc @Mic92 @ivan just bumping this PR. I think it got lost over the weekend. All the comments have been resolved.

@ivan
Copy link
Member

ivan commented Aug 7, 2019

@GrahamcOfBorg build ripgrep-all

@Mic92 Mic92 merged commit 31244a4 into NixOS:master Aug 7, 2019
@zaninime zaninime deleted the rga branch July 30, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

@mmahut mmahut

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zaninime @Mic92 @ivan @grahamc @mmahut