Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urh: add support for Pluto, soundcards, and optionally USRP #65671

Merged
merged 1 commit into from Aug 3, 2019
Merged

urh: add support for Pluto, soundcards, and optionally USRP #65671

merged 1 commit into from Aug 3, 2019

Conversation

ThibautMarty
Copy link
Member

@ThibautMarty ThibautMarty commented Jul 31, 2019 •
edited

This adds native support of Pluto SDR in URH.

  • libusb-1 support is needed and added in libiio
  • this triggers installation of an udev rule that needed some patches
  • Libiio is added in urh dependencies to enable native PlutoSDR support

I have tested basic functionalities with a Pluto SDR I own under NixOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz @thoughtpolice @markuskowa

@ofborg ofborg bot requested review from thoughtpolice and fpletz July 31, 2019 16:43
@ThibautMarty ThibautMarty changed the title urh: add PlutoSDR support [WIP] urh: add PlutoSDR support Jul 31, 2019
@ThibautMarty
Copy link
Member Author

Please wait a few hours: I want to be sure than libusb1 is actually needed (I added it during the iterations to make it work) but I don't have the SDR right now to test.
I also put libiio in propagatedBuildInputs instead of buildInputs, I'll fix it.

@ThibautMarty ThibautMarty changed the title [WIP] urh: add PlutoSDR support urh: add support for Pluto, soundcards, and optionally USRP Aug 1, 2019
@ThibautMarty
Copy link
Member Author

Finally:

  • libusb1 is needed in libiio for Pluto
  • libiio enables Pluto SDR support
  • pyaudio enables soundcard support
  • uhd enables USRP support
    USPR support is disabled by default because uhd comes with it is >400 MB of unused bitstreams. It may be possible to split uhd into multiple outputs to only depend on the library.

I successfully tested Pluto SDR support under NixOS with libiio's udev rule installed, but did not try others.

UHR should work under darwin, but I'm unable to test it.

Relevent UHR's documentation:

@markuskowa
Copy link
Member

markuskowa commented Aug 2, 2019 •
edited

@GrahamcOfBorg build urh

@ThibautMarty
Copy link
Member Author

Can we force GrahamcOfBorg to build for darwin?

@markuskowa
Copy link
Member

URH is marked for linux only in the meta.plattforms attribute. OfBorg won't build it (I dont' know if there's a way to force it).

@markuskowa markuskowa merged commit bb03799 into NixOS:master Aug 3, 2019
@ThibautMarty ThibautMarty deleted the fix/urh-pluto branch November 24, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa left review comments

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThibautMarty @markuskowa