New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jupyter #65824
Update jupyter #65824
Conversation
@GrahamcOfBorg build python3Packages.json5 python3Packages.jsonschema python3Packages.jupyter_core python3Packages.jupyter_client python3Packages.jupyterlab python3Packages.jupyterlab_server |
doing the nix-review of this right now..... maybe hold off due to jsonschema>3.... causing a lot of packages to be.... not happy |
2e9f018
to
53e540d
Compare
@GrahamcOfBorg build python3Packages.jupyter_core python3Packages.jupyter_client python3Packages.jupytext |
53e540d
to
6b5a710
Compare
I had to remove the jupyterlab* packages because they depended on jsonschema>=3, which is largely incompatible with the rest of python packages. |
@GrahamcOfBorg build python3Packages.jupyter_core python3Packages.jupyter_client python3Packages.jupytext python2Packages.jupyter_core python2Packages.jupyter_client python2Packages.jupytext |
@jonringer You could add a separate |
@veprbl that may work for non-python packages, however, python packages all share the same PYTHONPATH, so importing a jupyter package, and something which requires jsonschema~=2.0 will break one of those packages, as you don't know which you'll get if you do a Shared global mutable state is the worse 😢 |
If i was making an application on the other-hand, i could do that. As I could wrap my application with a specific PYTHONPATH. Since i have to worry about downstream packages, i can't in this case :( |
see #65023 (comment) for more context |
@jonringer |
@veprbl as soon as we let this in we open the door for more such cases. No, we are not going to do this. |
6b5a710
to
f314fdb
Compare
@FRidh i removed the need for having a different version of a package, this PR should be good to merge |
Motivation for this change
Wanted to fix the build of jupyterlab... then just decided to update them all.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @FRidh @timokau @costrouc