Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kustomize: 3.0.0 -> 3.1.0 #65746

Merged
merged 2 commits into from Aug 2, 2019
Merged

kustomize: 3.0.0 -> 3.1.0 #65746

merged 2 commits into from Aug 2, 2019

Conversation

AtkinsChang
Copy link
Contributor

Motivation for this change

Bump to latest release : release notes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vdemeester

@vdemeester
Copy link
Member

@GrahamcOfBorg build kustomize

vdemeester
vdemeester approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@ofborg ofborg bot requested review from kalbasit and periklis August 1, 2019 19:52
@kalbasit
Copy link
Member

kalbasit commented Aug 1, 2019

@GrahamcOfBorg build kustomize

@AtkinsChang
Copy link
Contributor Author

I fixed another bug since d567c48

@xrelkd
Copy link
Contributor

xrelkd commented Aug 2, 2019

@GrahamcOfBorg build kustomize
(build kustomize again on x86_64-linux and aarch64-linux)

@kalbasit kalbasit merged commit c64c5a3 into NixOS:master Aug 2, 2019
@AtkinsChang AtkinsChang deleted the update-kustomize branch August 8, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@kalbasit kalbasit kalbasit approved these changes

@periklis periklis Awaiting requested review from periklis

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AtkinsChang @vdemeester @kalbasit @xrelkd