Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solr: 7.6.0 -> 7.7.2 [backport] #65795

Closed
wants to merge 1 commit into from
Closed

solr: 7.6.0 -> 7.7.2 [backport] #65795

wants to merge 1 commit into from

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Aug 2, 2019

Motivation for this change

https://lucene.apache.org/solr/7_7_2/changes/Changes.html#v7.7.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse
Copy link
Member Author

aanderse commented Aug 2, 2019

@GrahamcOfBorg test solr

@ofborg ofborg bot requested review from rickynils and domenkozar August 2, 2019 15:09
@srhb
Copy link
Contributor

srhb commented Aug 3, 2019

Is this not a major version bump? The fact that it has actual update notes suggests to me that we shouldn't backport. If it is indeed reasonable, then why?

@aanderse
Copy link
Member Author

aanderse commented Aug 3, 2019

@srhb I was under the impression this is a minor release though now that you mention and I have fully reviewed the notes I'm unclear. I'll close this for now, but if I find out this is a standard stable release I'll open again. Thanks!

@aanderse aanderse closed this Aug 3, 2019
@aanderse aanderse deleted the solr-backport branch August 21, 2019 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickynils rickynils Awaiting requested review from rickynils

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @srhb