gradle: declare package major versions #65720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionello
force-pushed
the
gradle-major-versions
branch
from
316df87
to
b8fdf32
Compare
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
lionello
force-pushed
the
gradle-major-versions
branch
from
b8fdf32
to
15d5a93
Compare
adisbladis
approved these changes
Aug 1, 2019
|
@NeQuissimus Since you authored the gradle derivation, any comments on this PR? |
|
Sorry, I had actually looked at this, must have forgotten to approve. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
gradlehas several packages declared for major_minor versions, but not for just major, which is more useful when declaring dependencies. Additionally, gradle really only depends onjre_headlessto function properly, but currently hasjdkas its dependency.Things done
gradle_2,gradle_3,gradle_4,gradle_5.java(similar to other packages), defaulting to currentjdk.sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @NeQuissimus @adisbladis