Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdcm: Fix on darwin (include ApplicationServices, Cocoa) #65808

Closed
wants to merge 1 commit into from
Closed

gdcm: Fix on darwin (include ApplicationServices, Cocoa) #65808

wants to merge 1 commit into from

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

https://hydra.nixos.org/build/97183867/nixlog/1

I don't have a Darwin machine to test, but it looks like that should fix it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 labels Aug 2, 2019
@risicle
Copy link
Contributor

risicle commented Aug 2, 2019

Testing on macos 10.13 - Cocoa is also needed. I find it's usually more productive to just take darwin as an argument and do any apple_sdk.frameworks digging within the package itself.

@JohnAZoidberg
Copy link
Member Author

Ah yeah, that's a good idea, I saw lots of other packages do it the other way.
Thanks for testing, does it work now?

@JohnAZoidberg JohnAZoidberg changed the title gdcm: Fix on darwin (include ApplicationServices) gdcm: Fix on darwin (include ApplicationServices, Cocoa) Aug 2, 2019
@risicle
Copy link
Contributor

risicle commented Aug 2, 2019

I don't have any DICOM files to hand but the binaries print their usage options.

@JohnAZoidberg
Copy link
Member Author

You can try gdcmviewer with the ultrasound file here: https://medistim.com/dicom/

@risicle
Copy link
Contributor

risicle commented Aug 3, 2019

👍 works

@JohnAZoidberg
Copy link
Member Author

#65932 has already done the same.

@JohnAZoidberg JohnAZoidberg deleted the fix-gdcm-darwin branch August 28, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JohnAZoidberg @risicle