Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 41d010fff610
Choose a base ref
...
head repository: NixOS/nix
compare: 399b6f3c4607
Choose a head ref
  • 5 commits
  • 10 files changed
  • 1 contributor

Commits on Aug 2, 2019

  1. Tweak min-free/max-free descriptions

    @edolstra
    edolstra committed Aug 2, 2019
    Copy the full SHA
    320126a View commit details
    Browse the repository at this point in the history

  2. Add a test for auto-GC 

    This currently fails because we're using POSIX file locks. So when the
garbage collector opens and closes its own temproots file, it causes
the lock to be released and then deleted by another GC instance.
    @edolstra
    edolstra committed Aug 2, 2019
    Copy the full SHA
    ec415d7 View commit details
    Browse the repository at this point in the history

  3. Use BSD instead of POSIX file locks 

    POSIX file locks are essentially incompatible with multithreading. BSD
locks have much saner semantics. We need this now that there can be
multiple concurrent LocalStore::buildPaths() invocations.
    @edolstra
    edolstra committed Aug 2, 2019
    1
    Copy the full SHA
    e349f2c View commit details
    Browse the repository at this point in the history

  4. Simplify 

    With BSD locks we don't have to guard against reading our own
temproots.
    @edolstra
    edolstra committed Aug 2, 2019
    Copy the full SHA
    a2597d5 View commit details
    Browse the repository at this point in the history

  5. nix-store --verify: Don't repair while holding the GC lock

    @edolstra
    edolstra committed Aug 2, 2019
    Copy the full SHA
    399b6f3 View commit details
    Browse the repository at this point in the history