nixos/prometheus-exporters: replace nobody/nogroup #65810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop using nobody/nogroup by default and use seperate users for each exporter instead.
Only define seperate users and groups when necessary.
|
@GrahamcOfBorg test prometheus-exporters.bind prometheus-exporters.blackbox prometheus-exporters.collectd prometheus-exporters.dnsmasq prometheus-exporters.dovecot prometheus-exporters.fritzbox prometheus-exporters.json prometheus-exporters.mail prometheus-exporters.minio prometheus-exporters.nginx prometheus-exporters.node prometheus-exporters.postfix prometheus-exporters.postgres prometheus-exporters.snmp prometheus-exporters.surfboard prometheus-exporters.tor prometheus-exporters.unifi prometheus-exporters.varnish prometheus-exporters.wireguard |
Ma27
approved these changes
Aug 2, 2019
|
@WilliButz awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Long overdue removal of nobody/nogroup from the exporters module.
Things done
When possible, exporters should use systemds
DynamicUser, this is now the default for all exporters.Because some exporters need filesystem access and such, they might still need a "real" user. For these scenarios it is possible to set
DynamicUser = falseand a user with a corresponding group will be created for that exporter to use, both following the pattern<exporter-name>-exporter(e.g.varnish-exporter).This way neither nobody/nogroup nor root is used and multiple exporters don't need to be run under one shared user, keeping their access to metric sources separated.
Also replaced
scriptbyExecStartfor the wireguard exporter.sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)/cc #55370