Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-support: Add p11_kit to appimage dependency set #65817

Merged
merged 1 commit into from Sep 23, 2019
Merged

build-support: Add p11_kit to appimage dependency set #65817

merged 1 commit into from Sep 23, 2019

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Aug 2, 2019

Motivation for this change

This was in the upstream list but missing from nixpkgs' list.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tilpner

tilpner
tilpner suggested changes Aug 2, 2019
View reviewed changes
Copy link
Member

@tilpner tilpner left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c45f7fc0450ecbe89e10a4403b0bdfa4d1a5cbc9 looks good, but there are unwanted Gitlab commits included. Please remove and force-push.

@bgamari
build-support: Add p11_kit to appimage dependency set
d1139e3 
This was in the upstream list but missing from nixpkgs' list.
@bgamari
Copy link
Contributor Author

bgamari commented Aug 2, 2019

Fixed.

@bgamari
Copy link
Contributor Author

bgamari commented Sep 23, 2019

Can someone merge this?

@Mic92 Mic92 merged commit 71daf2d into NixOS:master Sep 23, 2019
@Mic92
Copy link
Member

Mic92 commented Sep 23, 2019

[detached HEAD 6e5766e] build-support: Add p11_kit to appimage dependency set
Author: Ben Gamari ben@smart-cactus.org
Date: Fri Aug 2 16:28:20 2019 -0400
1 file changed, 1 insertion(+)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilpner tilpner tilpner approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bgamari @Mic92 @tilpner