spidermonkey_{38,60}: fix cross compilation #65758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build spidermonkey_38 spidermonkey_60 elinks mediatomb pkgsCross.aarch64-multiplatform.spidermonkey_38 pkgsCross.aarch64-multiplatform.spidermonkey_60 |
This is essentially the same as done in 65f2b0a. For spidermonkey_38 I set --enable-posix-nspr-emulation, as it would otherwise complain about a wrong NSPR version and that trick seemed to be successful in spidermonkey_60 anyway.
erictapen
force-pushed
the
spidermonkey-fix-cross
branch
from
0ae8f23
to
002463d
Compare
|
@GrahamcOfBorg build spidermonkey_38 spidermonkey_60 elinks mediatomb pkgsCross.aarch64-multiplatform.spidermonkey_38 pkgsCross.aarch64-multiplatform.spidermonkey_60 |
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 501+
10.rebuild-linux: 1001-2500
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix cross compilation.
Things done
52, but for38and60.38I also set--enable-posix-nspr-emulation, as it would otherwise complain about a wrong NSPR version and that trick seemed to be successful in60anyway.Also I removed some version bounds on
mediatombandelinksas I didn't manage to cross compilespidermonkey_1_8_5. These two packages still don't cross compile, but i guess this brings them one step further on doing so.While working on this I figured that we probably don't need that many versions of
spidermonkeyor that one could at least remove some redundancy be creating ageneric.nix. But I guess that should better be done in a separate PR.#51134 can be closed btw.
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @cillianderoiste @abbradar @Phreedom