Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix home-assistant netatmo support #60947

Merged
merged 1 commit into from May 20, 2019
Merged

Fix home-assistant netatmo support #60947

merged 1 commit into from May 20, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented May 4, 2019

Motivation for this change

The netatmo components for home-assistant are broken in current nixpkgs due to a missing dependency. That dependency (pyatmo) happens to not be packaged yet, so I'm adding it to nixpkgs as part of this PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth delroth requested a review from FRidh as a code owner May 4, 2019 22:24
@delroth
Copy link
Contributor Author

delroth commented May 4, 2019

(FYI: @dotlambda since you're hass maintainer)

@delroth delroth mentioned this pull request May 4, 2019
Merged
10 tasks
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pyatmo python3.pkgs.pyatmo

@dotlambda
Copy link
Member

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase.

@delroth
Copy link
Contributor Author

delroth commented May 5, 2019

Upstream has no tests for this package.

@dotlambda
Copy link
Member

In that case, please set doCheck = false and add a comment with the reason.

@delroth
Copy link
Contributor Author

delroth commented May 5, 2019

Looking at long term maintenance, wouldn't it be better to keep the default checkPhase? If we do and upstream adds tests, it will either transparently work or require us to take further action at that time (disable or fix). Whereas if we doCheck = false it seems like there's potential for it slipping through a version bump unnoticed.

I also don't see C++ autotools packages disabling the default checkPhase when "make check" does nothing, which is akin to this situation.

</nitpicking> (but really I'm just trying to understand better if there's an established convention, and why)

@dotlambda
Copy link
Member

I've never really understood the convention, but it's what FRidh wants.

@dotlambda dotlambda changed the base branch from master to staging May 7, 2019 12:55
dotlambda
dotlambda requested changes May 7, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-run parse-requirements.py.

@delroth delroth changed the base branch from staging to master May 18, 2019 16:34
@delroth
Copy link
Contributor Author

delroth commented May 18, 2019

@dotlambda rebased onto 0.92 changes. GitHub never sent me an email notification about you changing the base branch of the PR so I was just waiting for 0.92 to get into master...

(And GitHub sucks as usual and decided to put everyone as reviewer. Sorry for the spam.)

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pyatmo python3.pkgs.pyatmo

@dotlambda dotlambda merged commit 042d76f into NixOS:master May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@delroth @dotlambda