New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix home-assistant fitbit support #60953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to wait with merging until #60217 is merged.
32dd0b3
to
c498898
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-run parse-requirements.py
.
@dotlambda rebased onto 0.92 changes. GitHub never sent me an email notification about you changing the base branch of the PR so I was just waiting for 0.92 to get into master... (And GitHub sucks as usual and decided to put everyone as reviewer. Sorry for the spam.) |
@GrahamcOfBorg build python2.pkgs.fitbit python3.pkgs.fitbit |
@GrahamcOfBorg build python2.pkgs.fitbit python3.pkgs.fitbit |
Motivation for this change
Similar to #60947. The fitbit components for home-assistant are broken in current nixpkgs due to a missing dependency. That dependency (python-fitbit) happens to not be packaged yet, so I'm adding it to nixpkgs as part of this PR.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)